Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureHttpRouter does not implement 'getRequestHostname'; breaks nest build #119

Closed
DenzoNL opened this issue Jan 31, 2020 · 4 comments
Closed

Comments

@DenzoNL
Copy link

DenzoNL commented Jan 31, 2020

I'm submitting a...


[ ] Regression 
[X] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

The @nestjs\azure-func-http\dist\router\azure-http.router.d.ts type definition is missing the getRequestHostname function declared in AbstractHttpAdapter. It is however, present in lib/router/azure-http.router.ts. If I manually add it, it all builds and runs just fine.

I'm thinking a build/publish might have gone wrong?

Environment


Nest version: 6.10.14

 
For Tooling issues:
- Node version: v12.14.1 
- Platform: Windows  

Others:

- @nestjs/azure-func-http version: 0.4.1
 (also present in 0.4.0, 0.3.2, haven't tested further back as the property didn't exist back then in AbstractHttpAdapter)
@kamilmysliwiec
Copy link
Member

Are you sure that you're on a 0.4.1 version? It should be fixed as a part of this release.

@rajeevbbqq
Copy link

@kamilmysliwiec Same error. and I'm using 0.4.1.

image

@DenzoNL
Copy link
Author

DenzoNL commented Feb 2, 2020

Are you sure that you're on a 0.4.1 version? It should be fixed as a part of this release.

My package.lock reads this, so yeah:

    "@nestjs/azure-func-http": {
      "version": "0.4.1",
      "resolved": "https://registry.npmjs.org/@nestjs/azure-func-http/-/azure-func-http-0.4.1.tgz",
      "integrity": "sha512-5Ee0a2oKQDqJq1IVMCxFO33N3Z5s+Z9W2lEY8UpauLsBnKumObxQBFnn+WUXUr2WQIm7AAV6u2r4G+x4C08vcg==",
      "requires": {
        "@angular-devkit/schematics": "8.3.22",
        "@schematics/angular": "8.3.22",
        "cors": "2.8.5",
        "trouter": "3.1.0"
      },

I will set up a repro tomorrow at work to make sure.

EDIT: Reproduction repository: https://github.com/DenzoNL/nest-azure-repro

@kamilmysliwiec
Copy link
Member

Fixed in 0.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants