Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows sandboxed processors broke #2092

Open
2 of 4 tasks
Mystos opened this issue May 14, 2024 · 2 comments
Open
2 of 4 tasks

Windows sandboxed processors broke #2092

Mystos opened this issue May 14, 2024 · 2 comments
Labels
bug Something isn't working needs triage

Comments

@Mystos
Copy link

Mystos commented May 14, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

When you register a new Queue for sandboxed process on windows, the job will failed instantly when spawned.

I've found out that bullMQ had this issue => taskforcesh/bullmq#2372

It was resolved by accepting URL object.

Also in "bull.provider" there is the creation of workers via the processor options. But there is 4 checks :

  • isAdvancedProcessor
  • isAdvancedSeparateProcessor
  • isSeparateProcessor
  • isProcessorCallback

And apparently if you have and URL object, none of the 4 checks go throught.

Should an PR be done to fix this issue ? And could there be other modification to be think of ?

I'm not really experienced in node and nest so sorry if I have overlook something.

Minimum reproduction code

https://github.com/Mystos/bull-nest-windows-sandboxed-error

Steps to reproduce

No response

Expected behavior

The sandboxed worker should accept URL object and string path to the processor file.

Package version

10.1.1

Bull version

5.7.8

NestJS version

10.0.0

Node.js version

No response

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@Mystos Mystos added bug Something isn't working needs triage labels May 14, 2024
@kamilmysliwiec
Copy link
Member

Would you like to create a PR for this issue?

@Mystos
Copy link
Author

Mystos commented May 15, 2024

@kamilmysliwiec I may be a bit too unfamiliar with NestJS and Node to do it. I've tried to do a quick fix, but I run into some TS problems that I can't find a solution for. If anyone more experienced would do it, I guess it could be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

2 participants