Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(interfaces): remove unused encoding option #1333

Merged
merged 1 commit into from Jun 14, 2023
Merged

refactor(interfaces): remove unused encoding option #1333

merged 1 commit into from Jun 14, 2023

Conversation

MansurAliKoroglu
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Intellisense for something that has no use.

Issue Number: N/A

What is the new behavior?

No more encoding intellisense.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I see no usage of encoding so removed it from the interface.

@kamilmysliwiec kamilmysliwiec changed the base branch from master to 3.0.0 June 14, 2023 12:26
@kamilmysliwiec kamilmysliwiec merged commit d524bdf into nestjs:3.0.0 Jun 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants