Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to disable all configurations merge one object #1501

Closed
1 task done
vanyastaff opened this issue Oct 18, 2023 · 1 comment
Closed
1 task done

Feature to disable all configurations merge one object #1501

vanyastaff opened this issue Oct 18, 2023 · 1 comment

Comments

@vanyastaff
Copy link

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

My problem access, I dont wanna share my configuration between modules and community library. Beacuse when I use ConfigModule in my project like registerAs() -> ConfigModule.forFeature() object grows with new configurations. First problem I cant use same token configuration because it will overwriten. Second I can write some lib wih using nest/config and inject it and get some user configurations them send it to my server. I think it is not safe.

Describe the solution you'd like

I think we should add option to aviable choose merge or not merge partials. Maybe like forFeature(databaseConfig, {global: false}) then I will see only one configuration object {database: {port: 3333}}

Teachability, documentation, adoption, migration strategy

I describe above

What is the motivation / use case for changing the behavior?

I describe above

@kamilmysliwiec
Copy link
Member

Thanks for your suggestion!

There are no plans to implement it in the foreseeable future.

If you think your request could live outside Nest's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

@nestjs nestjs locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants