Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to platform-fastify v9 #2502

Closed
1 task done
sam-super opened this issue Nov 11, 2022 · 1 comment
Closed
1 task done

Upgrade to platform-fastify v9 #2502

sam-super opened this issue Nov 11, 2022 · 1 comment
Labels

Comments

@sam-super
Copy link
Contributor

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

Because it would be nice to use a more modern versions of fastify and also to get rid of this warning:

(node:78725) [FST_MODULE_DEP_FASTIFY-FORMBODY] FastifyWarning.fastify-formbody: fastify-formbody has been deprecated. Use @fastify/formbody@6.0.0 instead.

Describe the solution you'd like

For @nestjs/apollo to be made compatible with @nestjs/platform-fastify at v9.

Teachability, documentation, adoption, migration strategy

No response

What is the motivation / use case for changing the behavior?

Being an outdated version of fastify (and platform-fastify) isn't great for the security and the health of the project in general (the further we get, the harder the upgrades will be).

From what i understand:

  1. @nestjs/platform-fastify: fastify version mismatch Apollo v3 requirements #2307 (comment)

Fastify v4 cannot be used with apollo-server-fastify v3. If you're using Fastify + NestJS + Apollo, I'd suggest not upgrading to v9 just yet

  1. apollo-server is relying on community modules to support fastify integration (since v4):
    https://github.com/apollographql/apollo-server/releases/tag/%40apollo%2Fserver%404.0.0 (See Removed web framework integrations)

  2. for @nestjs/graphql to support fastify v4 we would need to integrate with another library to support apollo-server with fastify v4.
    There are some recommended libs for this:
    https://www.apollographql.com/docs/apollo-server/integrations/integration-index/
    https://www.npmjs.com/package/@as-integrations/fastify

(Apologies if i have misunderstood any of this, or if it is already on a roadmap, but i just wanted to check).

@kamilmysliwiec
Copy link
Member

We're already tracking this here #2307 (comment) and here #2445

@nestjs nestjs locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants