Code First Subscription Filter arguments empty

[ptheofan]

Is there an existing issue for this?

• I have searched the existing issues

Current behavior

In the following code, variables are empty object and the generated schema is missing the arguments.

  @Subscription(() => Vote, {
    nullable: true,
    filter: (payload, variables: { id: string }) => {
      console.log('FILTER:', payload, variables);
      return payload.voteUpdate.id === variables.id;
    },
  })
  voteUpdate(): AsyncIterator<Vote> {
    return pubSub.asyncIterator('voteUpdate');
  }

Schema should have the arguments

type Subscription {
  voteUpdate: Vote
}

Minimum reproduction code

https://github.com/ptheofan/nestjs-subscription-filter-issue

Steps to reproduce

1. yarn
2. yarn start:dev
3. the generated schema is wrong
4. navigate to http://localhost:3000/graphql
5. create a subscription

## Arguments missing from schema, should be there.
subscription Subscription {
  voteUpdate(id: $id) {
    id
    value
  }
}

## should have arguments
{
  "id": "default"
}

7. UpVote (should trigger the subscription)

mutation UpVote($upVoteId: String!) {
upVote(id: $upVoteId) {
    id
    value
  }
}
## with arguments
{
  "upVoteId": "default"
}

9. Subscription is triggered, payload is correct, variables is empty object (should have the { id: 'default' })

Expected behavior

The subscription in the schema should have the expected arguments and filter variables object should not be empty.

Package version

12.0.9

Graphql version

"@apollo/server": "^4.9.4",
"@nestjs/apollo": "^12.0.9",
"@nestjs/graphql": "^12.0.9",
"graphql": "^16.8.1",
"graphql-subscriptions": "^2.0.0",
"graphql-ws": "^5.14.1",

NestJS version

10.2.7

Node.js version

v18.16.1

In which operating systems have you tested?

• macOS
• Windows
• Linux

Other

No response

[ptheofan]

My bad, was missing the @Args directive on the function.