Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow object for overriding private key when signing #1147

Conversation

39hn-zz
Copy link

@39hn-zz 39hn-zz commented Nov 16, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

It must be able to pass an object { key, passphrase } as privateKey for RSA and ECDSA algorithm.
It's possible on module option but not on overriding private key when signing.

What is the new behavior?

Fix privateKey type to allow to pass object for overriding private key when signing

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@micalevisk
Copy link
Member

could you please change the line below from npm@latest to npm@^8 to fix the pipeline

command: npm install -g npm@latest

@39hn-zz
Copy link
Author

39hn-zz commented Nov 17, 2022

could you please change the line below from npm@latest to npm@^8 to fix the pipeline

command: npm install -g npm@latest

sure!!

@david-a
Copy link

david-a commented Jan 31, 2023

Hi, I haven't noticed your PR and opened a similar one, but with tests and no other changes (e.g. config.yml)
#1192

@kamilmysliwiec kamilmysliwiec merged commit 5efbb1c into nestjs:master Feb 9, 2023
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants