Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create build using latest code #568

Closed
1 of 4 tasks
zoe-codez opened this issue Dec 2, 2021 · 5 comments
Closed
1 of 4 tasks

Create build using latest code #568

zoe-codez opened this issue Dec 2, 2021 · 5 comments

Comments

@zoe-codez
Copy link

zoe-codez commented Dec 2, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

The code published to NPM does not correspond with github code, root package.json doesn't seem to be receiving version bumps to properly publish

Minimum reproduction code

N/A

Steps to reproduce

yarn add @nestjs/mapped-types

Expected behavior

Installing this package should use the latest version. Bumping dependency versions in the package.json should at some point result in a build that can be pulled down and installed

Package version

1.0.0

Node.js version

No response

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

I am specifically attempting to resolve the class-transformer warnings I am getting while installing. The fix appears to already be in the code here, but I can't pull it in

@micalevisk
Copy link
Member

I think this has something with your lockfile because

npm info @nestjs/mapped-types version

outputs 1.0.0

@micalevisk
Copy link
Member

try pinning the version yarn add @nestjs/mapped-types@1.0.0

@zoe-codez
Copy link
Author

The content of that 1.0.0 is different from head in git if you go into the node_modules and look at the package.json.

2021-12-02_11-06

It looks like the dependencies package file were updated, but the version was left at 1.0.0. NPM should be rejecting those publishes with an error like You cannot publish over the previously published versions: ###. The version number must be incremented in order to publish properly

@micalevisk
Copy link
Member

oh I had misunderstood that. You're right

image
image

@kamilmysliwiec
Copy link
Member

Fixed in 1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants