Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for class-validator 0.14.0 #933

Closed
1 task done
rohanrajpal opened this issue Dec 31, 2022 · 4 comments
Closed
1 task done

Support for class-validator 0.14.0 #933

rohanrajpal opened this issue Dec 31, 2022 · 4 comments

Comments

@rohanrajpal
Copy link

Is there an existing issue that is already proposing this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

Updated my deps today & came across this warning

 WARN  Issues with peer dependencies found
apps/api
└─┬ @nestjs/mapped-types 1.2.0
  └── ✕ unmet peer class-validator@"^0.11.1 || ^0.12.0 || ^0.13.0": found 0.14.0

Describe the solution you'd like

I guess we can bump up peer deps to 0.14.0 since there arent any breaking changes?

Teachability, documentation, adoption, migration strategy

I dont think so these would be required.

What is the motivation / use case for changing the behavior?

To support class-validator 0.14.0 and future versions

@rnkdsh
Copy link

rnkdsh commented Dec 31, 2022

+1

@Ilyes512
Copy link

Ilyes512 commented Jan 1, 2023

There is already an automated (Renovate) PR: #930

This PR can be closed after the above has been merged: #926

@maintainers:
I guess its not as easy as just merging the PR (or otherwise it would have already happend?). Maybe someone can share some details about what might be blocking merging the dep update PR?

@kamilmysliwiec
Copy link
Member

Let's track this here #930

@joyheron
Copy link

joyheron commented Jan 2, 2023

Hi! We're having an issue with our automated updates because this causes a conflict with the peer dependencies in our project (our renovate bot automatically updates our class-validator dependency to 0.14.0 which then conficts with the ^0.11.1 || ^0.12.0 || ^0.13.0 required by mapped-types). We would appreciate it if this could be merged and released quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants