perf: Return MongooseError

nestjs · Oct 27, 2022 · 923ca93 · 923ca93
1 parent fa2491e
commit 923ca93
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/lib/interfaces/mongoose-options.interface.ts b/lib/interfaces/mongoose-options.interface.ts
@@ -9,7 +9,7 @@ export interface MongooseModuleOptions
   retryDelay?: number;
   connectionName?: string;
   connectionFactory?: (connection: any, name: string) => any;
-  connectionError?: (error: MongooseError) => void;
+  connectionError?: (error: MongooseError) => MongooseError;
 }
 
 export interface MongooseOptionsFactory {

diff --git a/lib/mongoose-core.module.ts b/lib/mongoose-core.module.ts
@@ -68,8 +68,7 @@ export class MongooseCoreModule implements OnApplicationShutdown {
           ).pipe(
             handleRetry(retryAttempts, retryDelay),
             catchError((error) => {
-              mongooseConnectionError(error);
-              throw error;
+              throw mongooseConnectionError(error);
             }),
           ),
         ),
@@ -107,7 +106,7 @@ export class MongooseCoreModule implements OnApplicationShutdown {
           connectionFactory || ((connection) => connection);
 
         const mongooseConnectionError =
-          connectionError || ((error) => {});
+          connectionError || ((error) => error);
 
         return await lastValueFrom(
           defer(async () =>
@@ -120,8 +119,7 @@ export class MongooseCoreModule implements OnApplicationShutdown {
           ).pipe(
             handleRetry(retryAttempts, retryDelay),
             catchError((error) => {
-              mongooseConnectionError(error);
-              throw error;
+              throw mongooseConnectionError(error);
             }),
           ),
         );