Merge pull request #1449 from liaoyinglong/fix/imports

fix: set flags from old node

lib/compiler/hooks/tsconfig-paths.hook.ts

@@ -36,6 +36,7 @@ export function tsconfigPathsBeforeHookFactory(
             }
             (newNode as any).moduleSpecifier = tsBinary.createLiteral(result);
             (newNode as any).moduleSpecifier.parent = (node as any).moduleSpecifier.parent;
+            (newNode as any).flags = node.flags;
             return newNode;
           } catch {
             return node;

test/lib/compiler/hooks/__snapshots__/tsconfig-paths.hook.spec.ts.snap

@@ -0,0 +1,23 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`tsconfig paths hooks should remove unused imports 1`] = `
+Map {
+  "dist/foo.js" => "\\"use strict\\";
+Object.defineProperty(exports, \\"__esModule\\", { value: true });
+exports.Foo = void 0;
+class Foo {
+}
+exports.Foo = Foo;
+",
+  "dist/bar.js" => "\\"use strict\\";
+Object.defineProperty(exports, \\"__esModule\\", { value: true });
+exports.Bar = void 0;
+class Bar {
+}
+exports.Bar = Bar;
+",
+  "dist/main.js" => "\\"use strict\\";
+Object.defineProperty(exports, \\"__esModule\\", { value: true });
+",
+}
+`;

test/lib/compiler/hooks/fixtures/type-imports/src/main.ts

@@ -0,0 +1,4 @@
+import { TypeA } from 'src/type-a';
+import type { TypeB } from 'src/type-b';
+import { TypeC } from './type-c';
+import type { TypeD } from './type-d';

test/lib/compiler/hooks/fixtures/type-imports/src/type-a.ts

@@ -0,0 +1 @@
+export type TypeA = number;

test/lib/compiler/hooks/fixtures/type-imports/src/type-b.ts

@@ -0,0 +1 @@
+export type TypeB = number;

test/lib/compiler/hooks/fixtures/type-imports/src/type-c.ts

@@ -0,0 +1 @@
+export type TypeC = number;

test/lib/compiler/hooks/fixtures/type-imports/src/type-d.ts

@@ -0,0 +1 @@
+export type TypeD = number;

test/lib/compiler/hooks/fixtures/unused-imports/src/bar.ts

@@ -0,0 +1 @@
+export class Bar {}

test/lib/compiler/hooks/fixtures/unused-imports/src/foo.ts

@@ -0,0 +1 @@
+export class Foo {}

test/lib/compiler/hooks/fixtures/unused-imports/src/main.ts

@@ -0,0 +1,2 @@
+import { Foo } from './foo';
+import { Bar } from 'src/bar';

test/lib/compiler/hooks/tsconfig-paths.hook.spec.ts

@@ -0,0 +1,55 @@
+import * as path from 'path';
+import * as ts from 'typescript';
+import { tsconfigPathsBeforeHookFactory } from '../../../../lib/compiler/hooks/tsconfig-paths.hook';
+
+function createSpec(baseUrl: string, fileNames: string[]) {
+  const options: ts.CompilerOptions = {
+    baseUrl,
+    outDir: path.join(baseUrl, 'dist'),
+    target: ts.ScriptTarget.ESNext,
+    module: ts.ModuleKind.CommonJS,
+  };
+
+  const program = ts.createProgram({
+    rootNames: fileNames.map((name) => path.join(baseUrl, name)),
+    options,
+  });
+  const output = new Map<string, string>();
+  program.emit(
+    undefined,
+    (fileName, data) => {
+      output.set(path.relative(baseUrl, fileName), data);
+    },
+    undefined,
+    undefined,
+    {
+      before: [tsconfigPathsBeforeHookFactory(options)],
+    },
+  );
+  return output;
+}
+
+describe('tsconfig paths hooks', () => {
+  it('should remove type imports', async () => {
+    const output = createSpec(path.join(__dirname, './fixtures/type-imports'), [
+      'src/main.ts',
+      'src/type-a.ts',
+      'src/type-b.ts',
+      'src/type-c.ts',
+      'src/type-d.ts',
+    ]);
+    output.forEach((value) => {
+      expect(value).toEqual(
+        `"use strict";\nObject.defineProperty(exports, "__esModule", { value: true });\n`,
+      );
+    });
+  });
+
+  it('should remove unused imports', async () => {
+    const output = createSpec(
+      path.join(__dirname, './fixtures/unused-imports'),
+      ['src/main.ts', 'src/foo.ts', 'src/bar.ts'],
+    );
+    expect(output).toMatchSnapshot();
+  });
+});