Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate new module - invalid regular expression at end of pattern #8

Closed
ddyrcz opened this issue Aug 1, 2017 · 4 comments
Closed

Comments

@ddyrcz
Copy link

ddyrcz commented Aug 1, 2017

I have blank new nest project generated with 'nest new app' command

When trying to generate new module with 'nest generate module newModule'

The: 'Invalid regular expression: //: \ at end of pattern' message appears

Whereas 'nest generate module new-module' works fine

CLI version: 1.7.0
Node version: 8.1.2

@thomrick
Copy link
Contributor

thomrick commented Aug 3, 2017

Hey @ddyrcz

Thanks for the issue.
I think that problem concerns only windows users because I can't reproduce the bug on MacOS.
I'm currently looking for to solve the problem but it's not quite easy.
I wish I could figure it out as soon as possible ;-)

@thomrick
Copy link
Contributor

thomrick commented Aug 3, 2017

I think I find the reason:
I don't use normalize path during the asset copy so it probably ran into an non windows friendly path.
Let's try to normalize it. :-)

@thomrick
Copy link
Contributor

thomrick commented Aug 3, 2017

Ok I found the bug !

new RegExp(path.sep);

doesn't work on Windows platform !!!

But that's not the only bug for Windows users ! A lot of work to do !
Thanks Unit Tests (I could see that if I run them on Windows platform) ><

@ddyrcz Thanks again :-)

@thomrick
Copy link
Contributor

thomrick commented Aug 6, 2017

Hey ! Please update your CLI to v1.7.5 !
I think there are other issues due to the difference between Unix and Windows platforms but this one is fixed.
Let me know the other issues you can find !
Thanks for your contribution

@thomrick thomrick closed this as completed Aug 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants