Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL does not accept DynamicModule type param #10494

Closed
3 of 15 tasks
CodyTseng opened this issue Nov 1, 2022 · 2 comments
Closed
3 of 15 tasks

REPL does not accept DynamicModule type param #10494

CodyTseng opened this issue Nov 1, 2022 · 2 comments
Labels
needs triage This issue has not been looked into

Comments

@CodyTseng
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

repl() function does not accept DynamicModule type parameter. I try to modify the parameter type of repl() to any, everything will be OK. So I think it's just a type error.

Minimum reproduction code

https://codesandbox.io/s/elastic-frog-etm26y?file=/src/repl.ts

Steps to reproduce

No response

Expected behavior

repl() function can accept DynamicModule type parameter.

Package

  • I don't know. Or some 3rd-party package
  • @nestjs/common
  • @nestjs/core
  • @nestjs/microservices
  • @nestjs/platform-express
  • @nestjs/platform-fastify
  • @nestjs/platform-socket.io
  • @nestjs/platform-ws
  • @nestjs/testing
  • @nestjs/websockets
  • Other (see below)

Other package

No response

NestJS version

9.1.6

Packages versions

"@nestjs/core": "^9.1.6"

Node.js version

16.14.2

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@CodyTseng CodyTseng added the needs triage This issue has not been looked into label Nov 1, 2022
@micalevisk
Copy link
Member

micalevisk commented Nov 1, 2022

PRs are more than welcomed 😸

export async function repl(module: Type) {

I would change that Type to Type | DynamicModule

@kamilmysliwiec
Copy link
Member

Let's track this here #10497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been looked into
Projects
None yet
Development

No branches or pull requests

3 participants