Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to using Axios v0.18 #1078

Closed
garvice-smartsheet opened this issue Sep 12, 2018 · 3 comments
Closed

Upgrade to using Axios v0.18 #1078

garvice-smartsheet opened this issue Sep 12, 2018 · 3 comments

Comments

@garvice-smartsheet
Copy link

I'm submitting a

[ ] Regression
[ ] Bug report
[ ] Feature request
[X] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Axios 0.17 has a bug in it that causes issue with maxContentLength not to be correctly set.

Expected behavior

Axios 0.18 has resolved this issue and is functioning correctly

Minimal reproduction of the problem with instructions

Send a file using the Nest's HttpService that is larger than 10mb.

What is the motivation / use case for changing the behavior?

We allow our users to upload files <= 30mb so as is we were blocked. However, we have created a service that will utilize the 0.18 version of Axios but we now have code that uses Nest's HttpService and special code that has the newer version of Axios. So far we haven't seen any issues doing this, but I'm always a little worried using two different versions of the same library and definitely don't want to have to maintain our version moving forward.

Environment

Nest version: 5.1, 5.2, 5.3 versions

@kamilmysliwiec
Copy link
Member

Fixed by #1152

@kamilmysliwiec
Copy link
Member

Done in 5.4.0

@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants