We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type error on server.keepAliveTimeout. This was previously working on older versions and seems to have broken when the interface was typed in d6a89fa
server.keepAliveTimeout
https://github.com/bmeverett/nest-keep-alive
Create a new NestJS application. In main.ts assign the app.listen call to a variable
main.ts
app.listen
When updating to NestJS 9.2.x and above the keepAliveTimeout is no longer able to be used on the response of app.listen()
keepAliveTimeout
app.listen()
const app = await NestFactory.create<NestExpressApplication>(AppModule); const server = await app.listen(3000); server.keepAliveTimeout = 30_000
I believe the type should be http.Server (it inherits from the generic Server)
http.Server
Server
Express Http Server
@nestjs/common
@nestjs/core
@nestjs/microservices
@nestjs/platform-express
@nestjs/platform-fastify
@nestjs/platform-socket.io
@nestjs/platform-ws
@nestjs/testing
@nestjs/websockets
No response
9.3
platform-express version : 9.3.9 schematics version : 9.0.4 testing version : 9.3.9 common version : 9.3.9 core version : 9.3.9 cli version : 9.2.0
18.7
The text was updated successfully, but these errors were encountered:
NestExpressApplication#listen
thanks for reporting! Let's track this here: #11280
I don't recall exactly why I chose net instead of http in there.
net
http
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Is there an existing issue for this?
Current behavior
Type error on
server.keepAliveTimeout
. This was previously working on older versions and seems to have broken when the interface was typed in d6a89faMinimum reproduction code
https://github.com/bmeverett/nest-keep-alive
Steps to reproduce
Create a new NestJS application.
In
main.ts
assign theapp.listen
call to a variableWhen updating to NestJS 9.2.x and above the
keepAliveTimeout
is no longer able to be used on the response ofapp.listen()
Expected behavior
I believe the type should be
http.Server
(it inherits from the genericServer
)Express
Http Server
Package
@nestjs/common
@nestjs/core
@nestjs/microservices
@nestjs/platform-express
@nestjs/platform-fastify
@nestjs/platform-socket.io
@nestjs/platform-ws
@nestjs/testing
@nestjs/websockets
Other package
No response
NestJS version
9.3
Packages versions
Node.js version
18.7
In which operating systems have you tested?
Other
No response
The text was updated successfully, but these errors were encountered: