Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

01-cats-app sample is broken due to an old version of core #12498

Closed
1 of 15 tasks
micalevisk opened this issue Oct 4, 2023 · 5 comments
Closed
1 of 15 tasks

01-cats-app sample is broken due to an old version of core #12498

micalevisk opened this issue Oct 4, 2023 · 5 comments
Labels
needs triage This issue has not been looked into

Comments

@micalevisk
Copy link
Member

micalevisk commented Oct 4, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

"dependencies": {
"@nestjs/common": "10.0.3",
"@nestjs/core": "10.0.3",

import { Reflector } from '@nestjs/core';
export const Roles = Reflector.createDecorator<string[]>();

but createDecorator was introduced in @nestjs/core v10.2

thus that code doesn't works

Minimum reproduction code

https://github.com/nestjs/nest/blob/49cf54e10aed6d30c47bad5975e5141ceeae1b1f/sample/01-cats-app

Steps to reproduce

No response

Expected behavior

bump the version of nestjs packages

We just need to merge some PR from Renovate bot. idk which one tho

Package

  • I don't know. Or some 3rd-party package
  • @nestjs/common
  • @nestjs/core
  • @nestjs/microservices
  • @nestjs/platform-express
  • @nestjs/platform-fastify
  • @nestjs/platform-socket.io
  • @nestjs/platform-ws
  • @nestjs/testing
  • @nestjs/websockets
  • Other (see below)

Other package

No response

NestJS version

No response

Packages versions

N/A

Node.js version

No response

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@micalevisk micalevisk added the needs triage This issue has not been looked into label Oct 4, 2023
@micalevisk micalevisk changed the title old version of core on 01-cats-app sample 01-cats-app sample is broken due to an old version of core Oct 4, 2023
@jmcdo29
Copy link
Member

jmcdo29 commented Oct 4, 2023

Are the other samples like this too? Might wanna update them all at once

@micalevisk
Copy link
Member Author

I don't think so https://github.com/nestjs/nest/pull/12237/files

@jmcdo29
Copy link
Member

jmcdo29 commented Oct 4, 2023

Looks like they are on older versions, but it's probably not an issue. Still, would be good to update them all to ^10.0.0 so they stay up to date as we keep publishing on v10

@micalevisk
Copy link
Member Author

micalevisk commented Oct 4, 2023

image

that entry from dependency dashboard will fix that

@kamilmysliwiec
Copy link
Member

Great catch @micalevisk, fixed #12500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been looked into
Projects
None yet
Development

No branches or pull requests

3 participants