Observable errors from websocket @SubscribeMessage are not caught by exception filters, causing server crash

[zakhenry]

I'm submitting a...

[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

If I return an observable that errors from within a @WebsocketGateway method that has @SubscribeMessage, the server crashes rather than invoking an error handler.

Expected behavior

Either the global error handler should catch the error and emit it to the client, or if set, the custom WsException.catch method should be invoked with the error.

Minimal reproduction of the problem with instructions

import { Injectable, UseFilters } from '@nestjs/common';
import { OnGatewayInit, SubscribeMessage, WebSocketGateway, WebSocketServer, WsResponse } from '@nestjs/websockets';
import { Observable, throwError } from 'rxjs';
import { map } from 'rxjs/operators';
import { Namespace, Socket } from 'socket.io';

@WebSocketGateway()
export class SocketGateway {

  @SubscribeMessage('ping')
  public pong(
    client: Socket,
    data: any,
  ): Observable<WsResponse<any>> {
    
    return throwError(); // this causes server crash, not a handled exception
  }
}

Environment

Nest version: 5.3.0

[kamilmysliwiec]

Thanks for reporting! Fixed by #1346

[zakhenry]

@kamilmysliwiec excellent thanks! Sorry it was a bit of a tough one to give a runnable repro for

[kamilmysliwiec]

Fixed in 5.5.0 :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.