Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpsOptions doesn't have SecureOptions #13070

Closed
5 of 15 tasks
tilak-puli opened this issue Jan 18, 2024 · 2 comments · Fixed by #13075
Closed
5 of 15 tasks

HttpsOptions doesn't have SecureOptions #13070

tilak-puli opened this issue Jan 18, 2024 · 2 comments · Fixed by #13075

Comments

@tilak-puli
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

NestJs create app doesn't have SecureOptions(which is present in HttpsOptions)

Minimum reproduction code

https://www.reddit.com/r/node/comments/n7s3km/nestjs_how_to_restrict_tls_cipher_suite/

Steps to reproduce

Nil

Expected behavior

I am trying to disable tlsv1.0 and v1.1 but I don't see SecureOptions in HttpsOptions.

Package

  • I don't know. Or some 3rd-party package
  • @nestjs/common
  • @nestjs/core
  • @nestjs/microservices
  • @nestjs/platform-express
  • @nestjs/platform-fastify
  • @nestjs/platform-socket.io
  • @nestjs/platform-ws
  • @nestjs/testing
  • @nestjs/websockets
  • Other (see below)

Other package

No response

NestJS version

8.1.3

Packages versions

Node.js version

No response

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@tilak-puli tilak-puli added the needs triage This issue has not been looked into label Jan 18, 2024
@kamilmysliwiec
Copy link
Member

Would you like to create a PR for this issue? This interface https://github.com/nestjs/nest/blob/d6a6f30165eb021797f6162e5bf7f4567b0189fa/packages/common/interfaces/external/https-options.interface.ts has to be updated (just add the secureOptions attribute)

@micalevisk micalevisk removed the needs triage This issue has not been looked into label Jan 19, 2024
@kamilmysliwiec
Copy link
Member

Let's track this here #13075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants