ApplicationReferenceHost.applicationRef.httpServer is undefined when using the FastifyAdapter

[BrunnerLivio]

I'm submitting a...

[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

When using the FastifyAdapter will make ApplicationReferenceHost.applicationRef.httpServer undefined.
In case you do not use FastifyAdapter, it will work as expected.

main.ts

NestFactory.create(
      ApplicationModule.forRoot(options),
      new FastifyAdapter(),
    );

terminus-bootstrap.service.ts

@Injectable()
export class TerminusBootstrapService implements OnApplicationBootstrap {
  constructor(
    private readonly refHost: ApplicationReferenceHost,
  ) {}

  public onApplicationBootstrap() {
    this.refHost.applicationRef.httpServer; // Returns null

  }
}

Expected behavior

It should return the underlying HttpServer

What is the motivation / use case for changing the behavior?

@nestjs/terminus does not work with FastifyAdapter because of this.

Environment

Nest version: 5.5.0

For Tooling issues:
- Node version: 10
- Platform:  Linux

Others:
https://github.com/nestjs/terminus/issues/24

[BrunnerLivio]

Fixed this issue with:

// httpServer for express, instance.server for fastify
const httpServer =
      this.refHost.applicationRef.httpServer ||
      this.refHost.applicationRef.instance.server;

Seems like instance.server returns the httpServer of fastify. I think this is a workaround, so I guess I leave this issue open for now?

[marcus-sa]

Now I can't remember exactly what interface applicationRef returns, but from looking at the adapters, calling getHttpServer() returns the correct server instance for both.

nest/packages/core/adapters/express-adapter.ts

Lines 90 to 92 in ff2e310

	getHttpServer<T = any>(): T {
	return this.httpServer as T;
	}

nest/packages/core/adapters/fastify-adapter.ts

Lines 83 to 85 in ff2e310

	getHttpServer<T = any>(): T {
	return this.instance.server as T;
	}

[BrunnerLivio]

@marcus-sa Perfect, works! This seems like a nice solution, closing :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.