Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Incorrect method name in the middlewares example #14

Closed
alexcorvi opened this issue Apr 11, 2017 · 4 comments
Closed

[Documentation] Incorrect method name in the middlewares example #14

alexcorvi opened this issue Apr 11, 2017 · 4 comments

Comments

@alexcorvi
Copy link

In this page You're referencing a method name getUsers, unfortunately this method does not exist in the users service. Instead You should have used getAllUsers.

Again, I know it's just an example for demonstration purposes, but nevertheless it should work.

Another question: is there a way to contribute to the documentation? It can be a tedious task for you to do alone, I'll be happy to help in anyway!

@kamilmysliwiec
Copy link
Member

Hi @alexcorvi again,
Many thanks! Now it should works fine.

If I remember properly, there is something like change requests in gitbook, so you can use it. It would be very helpful :)!

@kamilmysliwiec
Copy link
Member

Update:
This method has been correct ;) You have to scroll down:

Notice: I added getUsers method to UsersService, which returns encapsulated list of stored users.

getAllUsers() returns promise, not just an array.

@alexcorvi
Copy link
Author

Oh I see!

@lock
Copy link

lock bot commented Sep 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants