I cannot have two modules with same name in application. Is this a bug or a feature?

[mikeconley12]

Current behavior

I cannot have two modules with same name in application. Only the first module will be available in the application. In my case, this is the AModule from "./my-a-module".

Input Code

Third party library

@Module({
    providers: [AService]
    exports: [AService]
})
export class AModule {
}

@Module({
    imports: [AModule],
    providers: [BService]
    exports: [BService]
})
export class BModule {
}

My code

import { BModule } from "third-party-library";
import { AModule } from "./my-a-module";

@Module({
    imports: [
    	AModule,
    	BModule
    ]
})
export class CModule {
}

Expected behavior

I am not sure if this is a bug. But I was expecting that I could have two separate Nest modules with same name.

Environment

"@nestjs/common": "^6.9.0",
"@nestjs/core": "^6.9.0"
 
For Tooling issues:
- Node version: v10.16.0
- Platform: Linux

[mikeconley12]

For example, I can have two variables in different Node.js modules. Or even in different NPM packages. I want to have different Nest.js modules with same name, but in different NPM packages.

And what are benefits of this limitation? Maybe I can override any module in an application? This is not obvious.

And I can have two or more DYNAMIC modules with same name in application.
How should I override dynamic modules?

[kamilmysliwiec]

See #3363

[mikeconley12]

@kamilmysliwiec
Thanks for the quick response! :) Does it fix my problem? When can it be merged to master?

[kamilmysliwiec]

It should fix your problem :) We'll merge it shortly.

[mikeconley12]

Awesome! Thank you!

[Superd22]

I actually encountered the same problem with providers sharing the same name instead of modules.
Thanks for such a quick PR @kamilmysliwiec !

[kamilmysliwiec]

Fixed in the latest release (modules with the same name)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.