2nd level interceptor not being invoked

[vivekkatta]

I'm submitting a...

[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

2nd level interceptor not being invoked.

I have a graphql resolver which has an intercepter A associated at the method level [UseInterceptors(A)]. The resolver method calls a service method which has another interceptor B associated [UseInterceptors(B)].

The interceptor A executes as expected but the interceptor B is not even invoked.

Expected behavior

Interceptor B and any other interceptor that is encountered in the lower layers must be invoked.

Minimal reproduction of the problem with instructions

https://github.com/vivekkatta/test-interceptor.git

What is the motivation / use case for changing the behavior?

Environment

Nest version: 5.0.0-RC.1

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

[kamilmysliwiec]

Hey @vivekkatta,
All decorators reflect the dynamic metadata on a chosen method/class, they don't override original methods at all, and thanks to that they might be easily unit-tested as normal classes/methods. This is an intended behavior and all of them will never affect a normal function execution because it could break too many existing codebases.

[vivekkatta]

Hi @kamilmysliwiec, I think you mis-understood my question. I am not expecting original method to be overwritten at all. All I am trying to do is build 2 different logging interceptors. One for Graphql resolvers (where the logging is done in a specific way) another more generic logging interceptor for all other methods.

My issue is that the graphql logging interceptor is called but the interceptor decorating another method called by the resolver is not being invoked.

Please see the same repo I have created. The 'entering' and 'exiting' log statements for the TestService method is not coming through since the interceptor's 'intercept' method is not being called.

Hope this makes sense.

Thanks for looking into this!

Best,
Vivek

[kamilmysliwiec]

This is exactly what I'm talking about @vivekkatta 🙂
This code (test.service.ts):

@UseInterceptors(VCInterceptor)
sum(): number {
  return 8;
}

won't call VCInterceptor because it is used inside the service.

[vivekkatta]

Ok understood. Any suggestions how I can implement entry and exit logging on the above method sum and similar methods like that?

[kamilmysliwiec]

@Use[..]() decorators don't override original methods. If you want to add logging that would affect a real method implementation, you have to create your own decorator. Perhaps, I'll provide a way to dynamically create a method based on the attached metadata in the future.

[vivekkatta]

I thought about creating a custom decorator...but it isn't as convenient as an around interceptor. I'll think of something...Thanks

BTW, the library is amazing!

[kamilmysliwiec]

Thank you a lot 🙂

[et]

@use.. decorators don't override original methods. If you want to add logging that would affect a real method implementation, you have to create your own decorator. Perhaps, I'll provide a way to dynamically create a method based on the attached metadata in the future.

Hi @kamilmysliwiec - Just wanted to provide some feedback that this has tripped me up. I think there's needs to be more explicit documentation that these really only work on controllers (or at least that's how I understand them).

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.