Exceptions are not handled in cascade way

[adrianbudzynski]

I'm submitting a...

[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Annotated controller API method by @UseFilters(NotFoundExceptionFilter) is ignored and used is a global exception handler. After global exception filter is commented out, NotFoundExceptionFilter works as expected.

const app = await NestFactory.create(AppModule);
app.useGlobalFilters(new AnyExceptionFilter());

or

providers: [AppService,
        {
            provide: APP_FILTER,
            useClass: AnyExceptionFilter,
        },
    ],

Expected behavior

Controller annotated exception filters should have higher priority than global exception filter.

Minimal reproduction of the problem with instructions

async function bootstrap() {
    const app = await NestFactory.create(AppModule);
    app.useGlobalFilters(new AnyExceptionFilter());
    await app.listen(process.env.PORT || 3000);
}

@Controller()
export class TestController {

    constructor() {
    }

    @Get('/')
    @Render('view')
    @UseFilters(NotFoundExceptionFilter)
    async index(@Param() params, @Res() res, @Headers() headers): Promise<any> {
        throw new NotFoundException();
    }
}

@Catch()
export class AnyExceptionFilter implements ExceptionFilter {
    catch(exception: any, host: ArgumentsHost) {
        const ctx = host.switchToHttp();
        const response = ctx.getResponse();
        const request = ctx.getRequest();

        response
            .status(500)
            .render('error/any-exception', {});
    }
}

@Catch(NotFoundException)
export class NotFoundExceptionFilter implements ExceptionFilter {

    catch(exception: any, host: ArgumentsHost) {
        const ctx = host.switchToHttp();
        const response = ctx.getResponse();
        const request = ctx.getRequest();

        response
            .status(404)
            .render('error/not-found-exception');
    }
}

What is the motivation / use case for changing the behavior?

I want to have global exception handler for any exception, and I want to override exception handler for just specific one controller for one exception type.

Environment

Nest version: 5.0.0

 
For Tooling issues:
- Node version: v9.4.0
- Platform:  Mac

Others:

[adrianbudzynski]

I think to resolve that issue, filters array used in invokeCustomFilters method in exceptions-handler.ts class should be reversed while it is initialized in setCustomFilters method in the same class. I am not sure if this change won't cause any additional problems, please correct me if I am wrong.

public invokeCustomFilters(exception, response): boolean {
    if (isEmpty(this.filters)) return false;

    const filter = this.filters.find(({ exceptionMetatypes, func }) => {
      const hasMetatype =
        !exceptionMetatypes.length ||
        !!exceptionMetatypes.find(
          ExceptionMetatype => exception instanceof ExceptionMetatype,
        );
      return hasMetatype;
    });
    filter && filter.func(exception, response);
    return !!filter;
  }

[kamilmysliwiec]

Fixed in v5.0.1. Thanks @adrianbudzynski 🙂

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.