Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude method bug of Fastify adapter's middleware consumer #7848

Closed
iamolegga opened this issue Aug 13, 2021 · 1 comment
Closed

exclude method bug of Fastify adapter's middleware consumer #7848

iamolegga opened this issue Aug 13, 2021 · 1 comment
Labels
needs triage This issue has not been looked into

Comments

@iamolegga
Copy link
Contributor

Bug Report

Current behavior

Middleware consumer exclude method works different:

  • when .forRoutes(MyController) is set after exclude it doesn't work and middleware does apply

  • when .forRoutes({ path: '*', method: RequestMethod.ALL }); is set after exclude it works and middleware doesn't apply

Input Code

https://github.com/iamolegga/fastify-routing-test/blob/master/src/app.module.ts#L17-L32

Expected behavior

exclude method should work the same way in both cases

Possible Solution

Environment


Nest version: X.Y.Z

 
For Tooling issues:
- Node version: v12.18.4
- Platform: Mac

Others:
@iamolegga iamolegga added the needs triage This issue has not been looked into label Aug 13, 2021
@Zclhlmgqzc
Copy link
Contributor

Duplicate #7511
try >=8.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage This issue has not been looked into
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iamolegga @kamilmysliwiec @Zclhlmgqzc