Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing domino dependency #1017

Closed
bartlomiejgawel opened this issue May 18, 2023 · 1 comment
Closed

Missing domino dependency #1017

bartlomiejgawel opened this issue May 18, 2023 · 1 comment

Comments

@bartlomiejgawel
Copy link
Contributor

bartlomiejgawel commented May 18, 2023

I'm submitting a...

[ ] Regression
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

After upgrading to Angular 16, I can see the following error:

./node_modules/@nestjs/ng-universal/dist/utils/domino.utils.js:8:15-32 - Error: Module not found: Error: Can't resolve 'domino' in '/node_modules/@nestjs/ng-universal/dist/utils'

It is thrown here:
https://github.com/nestjs/ng-universal/blob/master/lib/utils/domino.utils.ts#L3

It looks like Angular dropped a dependency to domino. Here you can see that it is included:
https://www.npmjs.com/package/@angular/platform-server/v/15.2.9?activeTab=dependencies

And here is not, hence the error:
https://www.npmjs.com/package/@angular/platform-server/v/16.0.0?activeTab=dependencies

After manually installing the latest version of domino, my app started working.

I will create a PR to add this dependency as a quick fix.

Expected behavior

Angular 16 should work fine with the latest package.

Minimal reproduction of the problem with instructions

  1. Create a brand new Angular (16) app.
  2. Install the latest @nestjs/ng-universal package (7.1.1).
  3. Run the app by executing the following command: npm run dev:ssr.

What is the motivation / use case for changing the behavior?

Support for the latest version of Angular.

Environment

Nest version: 9.*.*
 
For Tooling issues:
- Node version: 18.16.0
- Platform: Mac, Linux, Windows
@kamilmysliwiec
Copy link
Member

Let's track this here #1018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants