Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture errors from angular ssr #77

Closed
tuurbo opened this issue May 15, 2019 · 1 comment
Closed

Capture errors from angular ssr #77

tuurbo opened this issue May 15, 2019 · 1 comment

Comments

@tuurbo
Copy link

tuurbo commented May 15, 2019

I'm submitting a...


[ ] Regression 
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Errors produced by angular ssr client code, for example error ApolloError: Network error: Http failure response for https://example.com/graphql: 504 Gateway Timeout or variable blahblah is undefined are logged to the node console. Setting logger in NestFactory to false does nothing.

const app = await NestFactory.create<NestExpressApplication>(ApplicationModule, {
    logger: false,
});

Would be nice to disable logging of all errors that come from angular or allowing them to be passed on to a custom logger, ex: sentry, bugsnag, console.log, etc...

Expected behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Nest version: 6.2.0

 
For Tooling issues:
- Node version: 12.1 
- Platform: 

Others:

@kamilmysliwiec
Copy link
Member

It's rather a feature to the nguniversal engine https://github.com/angular/universal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants