Forward Passport's info

[sroze]

When using passport-http to provide some Basic authentication, I don't receive the Realm in the failure response and therefore I'm not prompted by the browser.

It is setting the realm as the failure reason. Because we ignore the info argument then it's never sent back to the client.

Any idea on how you'd see this working? I'm happy to do the PR.

[dreamdevil00]

Sometimes we want to know why the authenticate process failed.For example, if the jwt token expired, the error info would be stored in info argument. But it is ignored. We can not get it anymore.

@kamilmysliwiec

thoughts?

[lutvianes]

For now, exception filter can be used to trigger Basic authentication prompt by browser. At least this code works for me.

@Catch(UnauthorizedException)
export class BasicAuthExceptionFilter extends BaseExceptionFilter<UnauthorizedException> {
    constructor(@Inject(HTTP_SERVER_REF) applicationRef?: HttpServer) {
        super(applicationRef)
    }

    catch(exception: UnauthorizedException, host: ArgumentsHost) {
        const ctx = host.switchToHttp();
        const response = ctx.getResponse();
        const request = ctx.getRequest();
        const status = exception.getStatus()

        if (request.authInfo) {
            response
                .status(status)
                .set('WWW-Authenticate', request.authInfo)
                .send()
        } else {
            super.catch(exception, host)
        }
    }
}

[kamilmysliwiec]

Done #29. Published as 6.1.0

[Roaders]

Many many thanks for that code snippet @lutvianes - there's really not much help available when googling why basic auth does not work in nest and your code fixed it for me. The only bit that was missing for me was hooking the filter up in my controller:

    @Get('timeBasic')
    @UseGuards(BasicAuthGuard)
    @UseFilters(BasicAuthExceptionFilter)
    getTimeBasic() {
        return this.appService.getTime();
    }

And a different constructor param for the filter (I think that HTTP_SERVER_REF has been deprecated)

import { BaseExceptionFilter, HttpAdapterHost } from '@nestjs/core';

@Catch(UnauthorizedException)
export class BasicAuthExceptionFilter extends BaseExceptionFilter<UnauthorizedException> {
    constructor(adapterHost: HttpAdapterHost) {
        super(adapterHost.httpAdapter);
    }