passport-facebook-token doesn't work

[ivanvs]

I'm submitting a...

[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

When I try to use passport-facebook-token library with this library I am getting this error:

TypeError: Class extends value undefined is not a constructor or null

/home/mrav/projects/gitdiagram-server/node_modules/@nestjs/passport/dist/passport/passport.strategy.js:13 class MixinStrategy extends Strategy {

I am trying to use given library like this:

import Strategy from "passport-facebook-token";
import { Injectable } from "@nestjs/common";
import { PassportStrategy } from "@nestjs/passport";

@Injectable()
export class GitHubStrategy extends PassportStrategy(Strategy) {
  constructor() {
    super({
      clientID: "client_id",
      clientSecret: "client_secret",
      passReqToCallback: true
    });
  }

  async validate(
    request: any,
    accessToken: string,
    refreshToken: string,
    profile,
    next: Function
  ) {
    try {
      console.log(profile);

      next(null, profile);
    } catch (err) {
      console.log(err);
      next(err, null);
    }
  }
}

I think that main problem is that passport-facebook-token is creating strategy by extending OAuth2Strategy and other libraries like passport-facebook are using util.inherits method. In node documentation util.inherits is deprecated.

As I can see nestjs/passport library is expecting Strategy to be function, link to source code.

Why I want to use passport-facebook-token strategy, because I want to implement implicit grant flow for my SPA application.

I have found one more library that is creating strategy in the same way:

• passport-github-token

Expected behavior

It would be nice if library would support strategies that are created by extending OAuth2Strategy.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Nest version: 6.0.0

 
For Tooling issues:
- Node version: v8.15.0 
- Platform:  Ubuntu

Others:

[kamilmysliwiec]

Please, provide a minimal repository which reproduces your issue.

[ivanvs]

Hi Kamil,

You can find simple example here: https://github.com/ivanvs/nestjs-passport-facebook-token-example

This example is not finished, so the whole flow for authentication is not implemented. I just put implementation of strategy and that implementation cannot be compiled.

If you need anything else, please do not hesitate to contact me.

[A-aras]

any update on this issue

[ivanvs]

@kamilmysliwiec would you be interested in PR that is fixing this issue? I can try to create a fix, and then you could review my solution.

What do you think about that?

[kamilmysliwiec]

Shouldn't this be fixed on the library (strategy) side instead? Also, are you sure that your issue isn't caused by the synthetic default import?

[ivanvs]

It was my mistake. Sorry for wasting your time :(

[shelooks16]

@ivanvs I bumped into exactly same issue:

TypeError: Class extends value undefined is not a constructor or null

I took the original package and transpiled it with @babel-plugin-transform-classes so now it returns a function.
https://www.npmjs.com/package/passport-facebook-token-nest

Works as expected:

import { Strategy } from 'passport-facebook-token-nest';

export class FacebookStrategy extends PassportStrategy(Strategy, 'facebook') {}