Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nestjs/core to peer dependencies #602

Closed
Nergie opened this issue Jul 28, 2021 · 3 comments
Closed

Add nestjs/core to peer dependencies #602

Nergie opened this issue Jul 28, 2021 · 3 comments

Comments

@Nergie
Copy link
Contributor

Nergie commented Jul 28, 2021

I'm submitting a...


[ ] Regression 
[X] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

@nestjs/core can't be resolved in my monorepo.
I get this error Cannot find module '@nestjs/core' .
I'm using lerna and yarn workspace to share modules across my packages.

@nestjs/schedule is installed in the project’s root node_modules.
@nestjs/core is installed in the node_modules of packages.
Folder architecture:
image

Expected behavior

Install @nestjs/schedule in the same folder as @nestjs/core

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Add @nestjs/core in the peer dependencies of @nestjs/schedule will fix this issue.

"peerDependencies": {
    "@nestjs/common": "^6.10.11 || ^7.0.0 || ^8.0.0",
    "reflect-metadata": "^0.1.12",
    "@nestjs/core": "^7.0.0 || ^8.0.0"
  },

Environment


Nest version: 8.Y.Z

 
For Tooling issues:
Nest version: 7.6.15

    "@nestjs/common": "^8.0.3",
    "@nestjs/config": "^1.0.1",
    "@nestjs/core": "^8.0.3",
    "@nestjs/event-emitter": "^1.0.0",
    "@nestjs/jwt": "^8.0.0",
    "@nestjs/passport": "^8.0.0",
    "@nestjs/platform-express": "^8.0.3",
    "@nestjs/schedule": "^1.0.0",
    "@nestjs/swagger": "^5.0.8",
 
For Tooling issues:
- Node version: v14.17.0
- Platform:  Mac

Others:
Using Yarn and Lerna
@kamilmysliwiec
Copy link
Member

Would you like to create a PR for this issue?

Nergie added a commit to Nergie/schedule that referenced this issue Jul 28, 2021
@Nergie
Copy link
Contributor Author

Nergie commented Jul 28, 2021

Would you like to create a PR for this issue?

Yes.
The PR is available here.
Thank you.

@kamilmysliwiec
Copy link
Member

Thanks @Nergie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants