Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(application): add spec option #1586

Merged
merged 1 commit into from Oct 30, 2023

Conversation

s5s5
Copy link
Contributor

@s5s5 s5s5 commented Oct 25, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: nestjs/nest-cli#2327

What is the new behavior?

The command nest g app some-app --no-spec will not add test files.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I've used unit tests to make sure the logic is correct, but I'm trying to use an npm link to get the local @nestjs/cli to call my modified @nestjs/schematics without success (when debugging @nestjs/cli, I find that he prints out logs for bin/nest.js, and logs for the other files don't show up).
Maybe I've succeeded, but I'm not sure. 馃ぃ

@kamilmysliwiec kamilmysliwiec merged commit ba4d987 into nestjs:master Oct 30, 2023
1 check passed
@kamilmysliwiec
Copy link
Member

lgtm

@s5s5 s5s5 deleted the s5s5/application-add-spec-option branch October 31, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants