fix: wrong package name when for edge cases #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micalevisk
commented
Feb 22, 2022
micalevisk
changed the title
4 tasks
micalevisk
force-pushed
the
fix/wrong-package-name
branch
from
653d264
to
bf60a60
Compare
micalevisk
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: closes nestjs/nest-cli#1540
nest new my.app grep name ./my.app/package.json # outputs the name entry with 'my'What is the new behavior?
after upgrading
@nestjs/schematicsdependency on https://github.com/nestjs/nest-cli,nest new my.app grep name ./my.app/package.json # outputs the name entry with 'my.app'Does this PR introduce a breaking change?
Other information