Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serveRoot doesn't work with fastify platform #1086

Open
2 of 4 tasks
ianzone opened this issue Mar 11, 2023 · 3 comments
Open
2 of 4 tasks

serveRoot doesn't work with fastify platform #1086

ianzone opened this issue Mar 11, 2023 · 3 comments
Labels
bug Something isn't working needs triage

Comments

@ianzone
Copy link

ianzone commented Mar 11, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

the route set on serveRoot will return 404

Minimum reproduction code

https://github.com/ianzone/lambda-nestify/tree/serve-static

Steps to reproduce

  1. pnpm i
  2. pnpm run dev
  3. go to /client

Expected behavior

return the static site

Package version

3.0.1

NestJS version

9.3.9

Node.js version

v18.12.0

In which operating systems have you tested?

  • macOS
  • Windows
  • Linux

Other

No response

@ianzone ianzone added bug Something isn't working needs triage labels Mar 11, 2023
@yiqia
Copy link

yiqia commented Mar 27, 2023

I also encountered this problem, and I used https://github.com/fastify/fastify-static solve

@ianzone
Copy link
Author

ianzone commented Mar 27, 2023

I also encountered this problem, and I used https://github.com/fastify/fastify-static solve

that's included in my reproduction repo

@ghost
Copy link

ghost commented Jul 12, 2023

@ianzone I think what @yiqia meant is that they use that package directly rather than via this nest module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

2 participants