Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadPackage function is duplicated from @nestjs/common #37

Closed
ruscon opened this issue Sep 28, 2019 · 2 comments
Closed

loadPackage function is duplicated from @nestjs/common #37

ruscon opened this issue Sep 28, 2019 · 2 comments
Labels

Comments

@ruscon
Copy link

ruscon commented Sep 28, 2019

I'm submitting a...


[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

loadPackage is used from file lib/utils/service-static.utils.ts

Expected behavior

loadPackage should be used from @nestjs/common

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


"@nestjs/serve-static": "1.0.1"

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@kamilmysliwiec
Copy link
Member

Would you like to create PR for this issue?

@ruscon
Copy link
Author

ruscon commented Oct 30, 2019

Yep, will do

@ruscon ruscon mentioned this issue Nov 11, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants