Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peerDependencies versions are too specific #363

Closed
3fd opened this issue Sep 11, 2019 · 1 comment
Closed

peerDependencies versions are too specific #363

3fd opened this issue Sep 11, 2019 · 1 comment

Comments

@3fd
Copy link

3fd commented Sep 11, 2019

I'm submitting a...


[ ] Regression 
[x] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Whenever a peer dependency version doesn't match the installed version exactly, npm displays warnings:


npm WARN @nestjs/terminus@6.5.1 requires a peer of @godaddy/terminus@4.1.2 but none is installed. You must install peer dependencies yourself.
npm WARN @nestjs/terminus@6.5.1 requires a peer of @nestjs/common@6.5.3 but none is installed. You must install peer dependencies yourself.
npm WARN @nestjs/terminus@6.5.1 requires a peer of @nestjs/core@6.5.3 but none is installed. You must install peer dependencies yourself.
npm WARN @nestjs/terminus@6.5.1 requires a peer of rxjs@6.5.2 but none is installed. You must install peer dependencies yourself.

Expected behavior

No warnings should be displayed for compatible peer dependency versions.

The version range for peer dependencies should be as wide as possible. It should at least include patch or minor versions.

Environment


Nest version: 6.6.7
@nestjs/terminus version: 6.5.1
@godaddy/terminus: 4.2.0
rxjs 6.5.3

 
For Tooling issues:
- Node version: 12.2.0 
- Platform: Linux 

Others:
- NPM version: 6.11.2

@BrunnerLivio
Copy link
Member

Thanks! Fixed it, will publish asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants