IsNotEmpty at Creation + IsEmpty at Update

[lapwat]

Hello everyone,

I cannot make this one working:

  @IsNotEmpty({ groups: [CREATE] })
  @IsEmpty({ groups: [UPDATE] })
  name: string

When I try to create with a name in my payload, the validator blocks the call: name must be empty.

Best,

[michaelyali]

Hi,
are you sure that you set those decorators right?
Here is the working example:

crud/integration/crud-typeorm/users/user.entity.ts

Lines 23 to 24 in b1f0924

	@IsOptional({ groups: [UPDATE] })
	@IsNotEmpty({ groups: [CREATE] })

I'm not sure that it's related to the crud lib itself, I have a feeling that you mess up with something in your project :(
If it's still an issue please provide me with the example repo.

[bamandine]

Hi,

I have the same issue : I have a required field for the creation of my object, but I don't want this field to be modified after.

With the @IsOptional({ groups: [UPDATE] }) option, the field is not required but I can still modify it if I put it on the request body.

Also, I try this :

  @IsDefined({ groups: [CREATE] })
  @IsEmpty({ groups: [UPDATE] })
  name: string

But same result : on PUT and PATCH, If I don't add the name field into the request body, I have an error :

"isDefined": "name should not be null or undefined"

[bamandine]

So, after some tests, we have found what was the problem: we had a ValidationPipe defined globally in our project. Once this global ValidationPipe removed, then the 2 validations are working.

[lapwat]

@bamandine I don't understand how a guard put at the global level can influence the behaviour of the decorator.

Disabling the global guard is a workaround ? Or is there some logical explanation for it to work ?

[bamandine]

@lapwat The global ValidationPipe had not been configured to use CRUD extension groups. I guess it was related.

[alisherafat01]

same issue for me, global validaton pipe should not be disabled for this issue and there is some problem with this lib

[rrufus]

@alisherafat01 I came across the same issue, I found the solution was on https://docs.nestjs.com/pipes#global-scoped-pipes

Global pipes are used across the whole application, for every controller and every route handler.

Note that in terms of dependency injection, global pipes registered from outside of any module (with useGlobalPipes() as in the example above) cannot inject dependencies since the binding has been done outside the context of any module. In order to solve this issue, you can set up a global pipe directly from any module using the following construction:

import { Module } from '@nestjs/common';
import { APP_PIPE } from '@nestjs/core';

@Module({
  providers: [
    {
      provide: APP_PIPE,
      useClass: ValidationPipe,
    },
  ],
})
export class AppModule {}

Having this in your AppModule makes the global validation pipe work.