Override decorator doesn't work on base class

[Diluka]

because of this

crud/src/decorators/crud.decorator.ts

Line 96 in e255120

Object.getOwnPropertyNames(prototype).forEach((name) => {

I can't put override method on base controller. It needs be overridden in crud decorated class.

[michaelyali]

The point of creating @Crud() decorator was to provide a possibility to have CRUD actions without any inheritance. So why do you create a base controller?

[Diluka]

since the lib doesn't support paging right now.
first, I try to override controller method to support it. I found every controller has the same code. then I try to use base controller, but failed.
after that, I try to override RepositoryService import from the lib (this is hack). then I found I created controllers all with a blank. I try to use forFeature but failed again #22 .

so why I need create controller with @Crud? all the crud requests shall be handled with GenericCrudController inside the lib.

If someone need override method, setup a route handle before the GenericCrudController and GenericCrudController skip the handled request. What do you think of this?

[michaelyali]

By saying that the lib doesn't support paging right now, what do you particular mean?

[Diluka]

I mean until #16 merged, I need to use getManyAndCount instead of getMany. But even if #16 has been merged, I still need format result like

{
    "list": [
        {
            "id": 1,
            "username": "player1"
        }
    ],
    "total": 1,
    "pages": 1,
    "size": 1,
    "pageNum": 1,
    "pageSize": 2,
    "startRow": 0,
    "endRow": 0
}

Now I am doing this.

export class PageInfo<T> {

  pageNum: number;
  pageSize: number;
  size: number;

  startRow: number;
  endRow: number;

  total: number;
  pages: number;

  list: T[];

  constructor(page: [T[], number], query: RequestParamsParsed) {
    const [list, total] = page;

    this.list = list;
    this.total = total;
    this.pages = Math.floor((total - 1) / query.limit) + 1;
    this.size = list.length;

    const offset = query.offset || (query.page - 1) * query.limit;

    this.pageNum = query.page;
    this.pageSize = query.limit;
    this.startRow = offset;
    this.endRow = offset + this.size - 1;
  }
}

RepositoryService.prototype.getMany = async function(query: RequestParamsParsed = {}, options: RestfulOptions = {}) {
  const builder = await this.buildQuery(query, options);
  if (query.page && query.limit) {
    const page = await builder.getManyAndCount();
    return new PageInfo(page, query);
  }
  return builder.getMany();
};

so I am finding a common way to override all the getMany method in controllers. that's why I need a base controller

[michaelyali]

ok, I got your point. So as I said here I'll do this improvement in the near future.

[Diluka]

I will look forward to it.