Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data types in filters #49

Closed
Diluka opened this issue Mar 27, 2019 · 0 comments · Fixed by #99
Closed

data types in filters #49

Diluka opened this issue Mar 27, 2019 · 0 comments · Fixed by #99
Assignees

Comments

@Diluka
Copy link
Contributor

Diluka commented Mar 27, 2019

query param ?filter=isOn||false will generate sql isOn = 'false' due to the false being traded as string

routing-controllers can even support json in query parameters.
Maybe we can do something like this when content-type is application/json:

try {
  value = JSON.parse(value);
} catch (ignored) {}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant