Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider ILog method overloads to accept a MethodInfo instance #82

Open
sbohlen opened this issue Feb 20, 2015 · 0 comments
Open

Consider ILog method overloads to accept a MethodInfo instance #82

sbohlen opened this issue Feb 20, 2015 · 0 comments

Comments

@sbohlen
Copy link
Member

sbohlen commented Feb 20, 2015

When logging is invoked from e.g., aspects/advice, Common.Logging reports the callsite of the log message as being in the aspect/advice rather than in the 'target' of the advice. While this is technically accurate/correct, its likely not what the reader of a log message really wants to see as the origin of the log message.

We should consider extending the ILog interface to offer overloads that accept an explicit MethodInfo or sim. parameter so that logging code can explicitly provide the callsite context which it would prefer Common.Logging to record as the 'logical' location of the source of the log message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant