KJR appears not to work (or works less) in KSP 1.5.1

[Lisias]

With really huge vessels, KJR appears to be ignored on KSP 1.5.1

This can be related to CPU - I heard that KSP 1.5.1 is more demanding (besides looking faster!), so perhaps KJR is not fully running on each frame. No exceptions were logged, however.

Perhaps a properly instrumented KJR would pinpoint the reason?

Evidences:

1. Huge vessel on my "production" KSP 1.4.5 with an awful :P amount of mods. The vessel collapses on launching due her own weight:
   

2. The very same vessel, with the very same KSP, but with 3.3.3.2 KJR installed. The vessel withholds very well.
   

3. The very same vessel on a mininum KSP 1.5.1 installment (only the needed mods, all updated to the last revisions) and KJR 3.3.3.2. The vessel collapses in the very same way as on the no-kjr 1.4.5 installment:
   

4. The very same vessel, with the very same mods (I just copied them from the 1.5.1 testbed!) running perfectly fine on a cleanest as possible KSP 1.4.5:
   

I need to further investigate this. People on 1.5.1 sooner or later will complain!

[Lisias]

Trying again, with a KJR-less 1.5.1+MH installment:

1. Before launch, without unbreakable joints Cheat:
   

2. Before launch, With unbreakable joints Cheat:
   

3. After launch, with unbreakable joints cheat disabled:
   

It appears to me that something is preventing KJR to run, or perhaps something on 1.5.1 changed and KJR instrumentation became innocuous.

Further testing is needed.

[Lisias]

While I typed the previous comment, everything blew up on the KSP! What a mess - I couldn't make a screenshot (damn it), but suddenly everything started to fly around with >Mach1 effects, then everything became blue, then everything disappeared.

All of this took about 2 to 3 minutes to happen, while KSP became halted ignoring keystrokes.

When I recovered the control, the focus was on the bottom of the ocean, with a negative altitude that appears to be at the center of Kerbin (>269K meters - negative). And no part had survived.

Attached are the logs of the event.

Yes, i really need to dig on this. =/

<decluttering the issue, that logs had a lot of unrelated problems>

[Lisias]

Just had word that this happens with smaller vessels too. So, yeah, KJR is just innocuous on 1.5.1 .

Previous reports about it working appears to be a misunderstanding between "it works" with "it don't fuck up everything". :)

Thanks for the heads up, shifty303 !

https://forum.kerbalspaceprogram.com/index.php?/topic/50911-13-kerbal-joint-reinforcement-v333-72417/&do=findComment&comment=3489563

[Lisias]

So, I did another test - this time, on a stock only game with TweakScale (that revealed itself not needed) and KJR 3.3.3.2.

1. Vanilla KSP 1.5.1+MH - pre launch:
   

2. Vanilla KSP 1.5.1+MH - after launch:
   

3. KSP 1.5.1+MH + KJR - after launch:
   

Craft:
KJR_Issue.craft.zip

Logs:
vessel_huge_testbed3_KSP.log
vessel_huge_testbed3_Player.log

No errors on the log. Not a single warning. KJR is, apparently, doing nothing.

[Lisias]

I recompiled the KJR 3.3.3.2 against 1.5.1 libraries, just for the peace of mind (as previous experiences already taught me when this can be a possibility).

No dice. Same thing. Logs follow:
vessel_huge_testbed4_KSP.log
vessel_huge_testbed4_Player.log

On a side note, I compiled it in Debug mode where a lot os debugging messages should had happened.

[Lisias]

I have definitive and incontestable evidence that this is not related to binary issues (i.e., recompiling is not enough).

I took the very DLL that I used on 1.5.1 (that was recompiled against 1.5.1 DLLs) and used it on 1.4.5. And the thing worked all right.

So… Yeah. Something really changed on KSP 1.5.1. :)

Logs from 1.4.5, using a specially compiled /L Experimental DLL:
vessel_huge_testbed5_145_KSP.log
vessel_huge_testbed5_145_Player.log

[Lisias]

EU SOU UM IDIOTA!!!! :D

Problem solved. It was simple. It was ridiculously simple. :D

KJR prevents itself from running when it detects an "incompatible" KSP. =P

I solved the problem by withdrawing the preventing code. The warning for an incompatible KSP was already issued, I don't find necessary to boycott the running - the user was already warned. :)

[Lisias]

Addendum:

Further tests on KSP 1.2.2 and 1.3.1 revealed the the very same binary for KJR 3.3.3.3 Experimental (compiled against 1.5.1 libraries) and KSPe 2.1 Pre-Release (compiled agains 1.4.1 libraries) worked flawlessly.

This means that at least KJR (probably some others add-ons) can be certified to run on 1.2 and 1.3 series using the very same binaries used on 1.4 and 1.5 - simplifying and expanding compatibility efforts.