Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N log N complexity instead of linear #205

Closed
hnarkaytis opened this issue Jun 2, 2020 · 3 comments
Closed

N log N complexity instead of linear #205

hnarkaytis opened this issue Jun 2, 2020 · 3 comments

Comments

@hnarkaytis
Copy link

netaddr/netaddr/ip/__init__.py

Line 1663 in ebf7146

sorted_ips = sorted(

Sorting is used only for finding min and max values in the sequence. Potentially input set might contain billions of elements and sorting will take unreasonable time.
@brianmaissy
Copy link

@jstasiak happy to open a PR for this if it's something you would merge

@jstasiak
Copy link
Contributor

Yes, absolutely, it'd be cool.

@brianmaissy brianmaissy mentioned this issue Jun 21, 2020
Closed
@jstasiak
Copy link
Contributor

jstasiak commented Jul 3, 2020

This has been fixed in 0.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

spanning_cidr doesn't need to sort all of its inputs brianmaissy/netaddr
3 participants
@jstasiak @brianmaissy @hnarkaytis