Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose which source file to extract comments from if they differ #98

Open
tylerjames opened this issue May 30, 2017 · 2 comments
Open
Labels

Comments

@tylerjames
Copy link

First: This tool is great. I hate strings files and handling localization on iOS, it's absurdly bad, but this is making it a bit better.

I have English and Japanese strings files. My English file contains my (the developer) comments. The Japanese file contains some comments added by the translator, or at least the person responsible for sorting out the translation.

When I run:
babelish strings2csv

It extracts the comments only from the second file. If anything I'd prefer it to extract the comments from the first file, ideally though it would get both and put them in different columns.

Is there any way to specify which comments to use or use both?

@netbe
Copy link
Owner

netbe commented May 31, 2017

@tylerjames I never had this case, but I would expect the comments to be the same on both files since strings files are usually manipulated by developers.

Besides if you take genstrings command it will populate both files with same comment from NSLocalizableString(, comment: ).

That said a feature could be to merge the comments or as you said specify which file to extract it from.

@tylerjames
Copy link
Author

Hi,

Yeah I realize this is probably a pretty edge case. I should really get my translation guy to keep his comments separate.

I might be able to just switch the order of the en and ja files and have it pull comments from the English.

@netbe netbe added the iOS label Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants