Release v0.3.0 #28
Merged
Release v0.3.0 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meter for the filename.
Android support PHP support Refactoring to use CSVBase class
… on a wrong expected output.
…generalize_converting_add_json # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…_add_json Feature/generalize converting add json
…dd_json Feature/generalize converting add json @Neoklosch @gernotlabahn Merging to develop in order to restructure all this together
| end | ||
|
|
||
| def test_create_file_from_path | ||
| test_file = "test_file.txt" |
There was a problem hiding this comment.
Use 2 (not 4) spaces for indentation.
| default_val = strings[self.default_lang][key] if strings[self.default_lang] | ||
| @filenames.each do |fname| | ||
| lang = fname | ||
| current_val = (lang != self.default_lang && strings[lang][key] == default_val) ? '' : strings[lang][key] |
There was a problem hiding this comment.
Don't use parentheses around the condition of an if/unless/while/until
Redundant self detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo is ready to be renamed and project has been reorganised