Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csv2android do not use language region #101

Closed
denis-stepuschik opened this issue Jan 10, 2018 · 2 comments
Closed

csv2android do not use language region #101

denis-stepuschik opened this issue Jan 10, 2018 · 2 comments
Labels
Android

Comments

@denis-stepuschik
Copy link

denis-stepuschik commented Jan 10, 2018 •
edited
Loading

Please change line 16 to this:

region = language.region.to_s.empty? ? "" : "-#{language.region}"
filepath = Pathname.new(@file_path) + "values-#{language.code}#{region}" + output_name
@netbe
Copy link
Owner

netbe commented Jan 10, 2018

@denis-stepuschik can you create a PR please?

@netbe netbe added the Android label Mar 8, 2018
@beloso beloso mentioned this issue May 29, 2018
Closed
@filippodelfra
Copy link

Hi,
Can we please have this feature merged?
I'm also facing this issue and would be good to have it.

Thanks!

@netbe netbe closed this as completed Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Android
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@netbe @filippodelfra @denis-stepuschik