-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to pick darker color? #18
Comments
Hi @msevestre, thanks for opening the issue. The goal of this component is to change colors in a HSL / HSV model. The color selection is not based on the image, but on the angle and position of the thumb. Changing the background image would not suffice, you would need to change how the color is retrieved. This is easy, and I would welcome a PR that is backgrounds compatible, but its implementation it's not planned. Related 👉 #13 |
I don't think this is related to #13 whatsoever. I am not asking for black color. Just asking for darker color for green.
Yes this is clear that some code will need to be implemented to make it work. But don't you think that this would make sense to have a green color range that is bigger (for a lack of a better word) that what is available now? The green is almost the same throughout the wheel area
I am not sure what you mean with background compatible. If you give me some pointers however on how this could be implemented, I could give it a try |
Sorry I meant backwards compatible (editing soon). I am afraid you already have available 360º of hue. The only way to get more green options, would be to have a higher definition, but I wonder how the user experience would be. You can turn a color darker, reducing it's luminosity or brightness, properties of the HSV format. Normally other color pickers offer a second spinner or UI element to increase the range of the colors, but this wheel is supposed to be the wheel only. I can't come up with an elegant and easy solution, knowing those restrictions. If you can come up with one, I'm open to it. More info about color and encodings: |
I understand that the color selection is based on the wheel.png file.
There are a lot of color variations for blue and red for example. It's almost impossible however to pick a dark green. Is there a reason for that?
Thanks,
Michael
The text was updated successfully, but these errors were encountered: