Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group is created twice, gets a "phantom peer" assigned and can't be deleted #1568

Closed
b00nish opened this issue Feb 12, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@b00nish
Copy link

b00nish commented Feb 12, 2024

Describe the problem

I tried to create a new Group during the creation of an Access Control Policy. The policy was supposed to have that same group as Source and Destination.
After doing so, I got not one but two new Groups (both with exactly the same name) under "Settings -> Groups".
Moreover both those Groups allegedly have a Peer assigned and therefore can't be deleted. Just that there is not one single Peer existing in that Netbird instance.
So I also can't get rid of the duplicated group because in order to do so I'd have to delete a "phantom peer" first, which I can't because there are 0 peers.

To Reproduce

I have not yet been able to reproduce the behaviour.
My (unproven) assumption is, that somehow by using the same group name in the Source and the Destination field I could trigger the creation of the same (or rather an identically named) group twice. Maybe because the creation of the "first" group (Source field) hasn't been finished when I entered the same name in the Destination field. But as I said: I couldn't reproduce it, so that's just a speculation.

Expected behavior

I expect not to have duplicate groups and phantom peers in my Netbird instance.

Are you using NetBird Cloud?

self-hosted

NetBird version

0.25.6

Screenshots

netbird1
Here you can see the same group twice, with each a peer assigned. (Don't mind the assigned setup-key, that one I added later but it had no influence on the situation.)

netbird2
Here you can see that there are no peers in that same instance. (In fact at the point where the duplicate groups were created, there never had been a peer in that freshly installed instance.)

Additional context

I'd love to know how to get rid of the duplicate groups.

@b00nish b00nish added the triage label Feb 12, 2024
@surik
Copy link
Contributor

surik commented Feb 13, 2024

These two PRs should fix the issue:
#1573
netbirdio/dashboard#328

@surik surik added bug Something isn't working and removed triage labels Feb 13, 2024
@b00nish
Copy link
Author

b00nish commented Feb 13, 2024

Thanks for the (again) very fast fix.
I can confirm that after the update the "phantom users" disappeared and the duplicated groups could be deleted.

@surik surik closed this as completed Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants