Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ERROR Resource path must not end with '/' but is '.../'" must be improved #6

Closed
kwin opened this issue Mar 12, 2020 · 0 comments · Fixed by #10
Closed

"ERROR Resource path must not end with '/' but is '.../'" must be improved #6

kwin opened this issue Mar 12, 2020 · 0 comments · Fixed by #10
Assignees
Milestone

Comments

@kwin
Copy link
Member

kwin commented Mar 12, 2020

Currently if one referenced resource ends with a slash the following exception is logged

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  49.602 s
[INFO] Finished at: 2020-03-12T09:33:12+01:00
[INFO] ------------------------------------------------------------------------
[DEBUG] No threads registered for execution at the end of the build
[ERROR] Failed to execute goal org.apache.jackrabbit:filevault-package-maven-plugin:1.1.0:validate-package (default-validate-package) on project nc-website-components-package: Execution default-validate-package of goal org.apache.jackrabbit:filevault-package-maven-plugin:1.1.0:validate-package failed: Resource path must not end with '/' but is '..../' -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.jackrabbit:filevault-package-maven-plugin:1.1.0:validate-package (default-validate-package) on project nc-website-components-package: Execution default-validate-package of goal org.apache.jackrabbit:filevault-package-maven-plugin:1.1.0:validate-package failed: Resource path must not end with '/' but is '/libs/core/wcm/components/teaser/v1/teaser/

This error message must be improved to at least emit the file path where the error occurred!
Also the debug log level does not help much as the previous output is
[DEBUG] ValidationViolation: "Validating jcr file '<some jcr file>'..." which is not the failing file but the previous one!

The issue can be easily reproduced by setting the value sling:resourceSuperType on a component definition to a value like core/wcm/components/teaser/v1/teaser/

The situation will improve with the upcoming FileVault 3.4.4 (https://issues.apache.org/jira/browse/JCRVLT-406)

kwin added a commit that referenced this issue Mar 12, 2020
Cleanup code to emit validation messages
This closes #6
kwin added a commit that referenced this issue Mar 12, 2020
Cleanup code to emit validation messages
This closes #6
@kwin kwin self-assigned this Mar 12, 2020
@kwin kwin added this to the 1.0.1 milestone Mar 12, 2020
@kwin kwin closed this as completed in #10 Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant