Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check caching strategy and performance of article loading #108

Closed
nc-andreashaller opened this issue Nov 29, 2022 · 4 comments
Closed

Check caching strategy and performance of article loading #108

nc-andreashaller opened this issue Nov 29, 2022 · 4 comments
Assignees
@verlok-cn

Comments

@nc-andreashaller
Copy link
Collaborator

See https://github.com/hlxsites/netcentric/pull/93/files#r1033235092
@nc-andreashaller nc-andreashaller mentioned this issue Nov 29, 2022
Merged
@verlok-cn
Copy link

verlok-cn commented Dec 21, 2022 •
edited
Loading

Hey @nc-andreashaller and @NCalexiaeche sorry I missed this, I will check.

@verlok-cn
Copy link

@nc-andreashaller what do you exactly mean with article loading?

@nc-andreashaller
Copy link
Collaborator Author

see the comment in https://github.com/hlxsites/netcentric/pull/93/files#r1033235092, the getArticles call is potentially done multiple times, the JavaScript the comment refers to is loaded for the Blog Post block which is to my knowledge loaded on all blog articles like https://www.netcentric.biz/insights/2022/12/collecting-the-right-data-to-deliver-personalized-experiences

@verlok-cn
Copy link

I have checked, it is always loaded from disk cache, so no optimisation required.

Screenshot 2022-12-23 at 18 01 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verlok-cn verlok-cn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nc-andreashaller @verlok-cn