Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration also via system properties in addition to environment variables #19

Closed
kwin opened this issue Jul 13, 2021 · 2 comments · Fixed by #22
Closed

Allow configuration also via system properties in addition to environment variables #19

kwin opened this issue Jul 13, 2021 · 2 comments · Fixed by #22
Assignees
Milestone

Comments

@kwin
Copy link
Member

kwin commented Jul 13, 2021

Currently the extension can be configured only via environment variables. To ease using it locally with the help of .mvn/jvm.config (https://maven.apache.org/configure.html#mvn-jvm-config-file) it should be possible to pass the configuration via system properties alternatively.

@kwin kwin self-assigned this Jul 13, 2021
@kwin kwin added this to the 1.2.0 milestone Jul 13, 2021
@ghenzler
Copy link
Member

ghenzler commented Jul 14, 2021

So I suppose the system property would be taken as fallback in case the env variable does not exist? (if the sys property is to take precedence, you would have to add .mvn/jvm.config to .gitignore which might be problematic for cases when you want to use jvm.config for other use cases)

@kwin
Copy link
Member Author

kwin commented Jul 14, 2021

The other way around seems more intuitive as System properties are Java process specific while Environment variables are usually OS wide. Why do you think this would be problematic? The chance for name clashes should be close to zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants