Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Top bar badges get cut with lower resolutions #159

Closed
hugovalente-pm opened this issue Oct 15, 2021 · 6 comments
Closed

[BUG] Top bar badges get cut with lower resolutions #159

hugovalente-pm opened this issue Oct 15, 2021 · 6 comments
Assignees
Labels

Comments

@hugovalente-pm
Copy link
Contributor

hugovalente-pm commented Oct 15, 2021

Describe the bug

With the introduction of the Lab features component the existing responsiveness issue of the top bar was highlighted, we took free space that gave manouvering margin on smaller screens.

Now the top bar War Room members and Nodes information badges gets cut on lower resolutions, e.g. 1152x732

Note: There is also a ticket on the Agent for this Agent dashboard top bar gets cut with lower resolutions #11735

To Reproduce
Steps to reproduce the behavior:

  1. Lower the resolution on your browser, using dev tools console for example
  2. Go to 1152x732 or lower
  3. See that War Room members badge is not there and Nodes one is cut

Expected behavior
A clear and concise description of what you expected to happen.

Figma link - https://www.figma.com/file/tUaZl2Wzh8KQZYdfdqBf4A/%23159--Top-bar-badges-get-cut-with-lower-resolutions?node-id=0%3A1

Screenshots

image

Error logs

N/A

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 94.0.4606.81 (Official Build) (64-bit)

Additional context

N/A

@hugovalente-pm hugovalente-pm changed the title [BUG] War Room members badge gets cut with lower resolutions [BUG] Top bar badges gets cut with lower resolutions Oct 15, 2021
@hugovalente-pm hugovalente-pm changed the title [BUG] Top bar badges gets cut with lower resolutions [BUG] Top bar badges get cut with lower resolutions Oct 15, 2021
@novykh
Copy link
Contributor

novykh commented Oct 15, 2021

how do you wish to handle this?

@hugovalente-pm
Copy link
Contributor Author

as discussed, let's get @anastako view on this we could change the text to an icon when there isn't enough space or something

@anastako
Copy link

@hugovalente-pm this is not a solution on my part. The only solution I see is to design a responsive header

@hugovalente-pm
Copy link
Contributor Author

@anastako to design a responsive header how long do you think it will take?

@anastako
Copy link

This last question affects more the development team, we can provide a responsive header as long as we are aligned on that with the stakeholders.

To fast track this bug these are the 3 solutions that we propose. It is not a matter of deciding which one of the three but all of them.

  1. Below 1280px width resolution the left navigation menu will collapse. When expanding will act as an overlay i.e. will not "push" the elements of the page.

  2. The spacing of the header element can be improved by lowering the whitespace/padding between elements

3)The date-time picker can be improved by auto-resizing concerning its contents. Also, the "▶️ Playing" can be shortened by removing the label since the visual metaphor is sufficient.

@hugovalente-pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants