Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When passing before and after as absolute value parameters on an URL these aren't respected #995

Closed
hugovalente-pm opened this issue Apr 2, 2024 · 3 comments
Assignees
Labels

Comments

@hugovalente-pm
Copy link
Contributor

Bug description

When a URL that contains the before and after parameters is opened in a new tab these aren't respected.
It seems if the absolute values are passed as value parameters they are converted to relative value parameters

Expected behavior

Before and After values should be respected

Steps to reproduce

  1. Select a specific time in the past
  2. Copy the URL that has the absolute values
  3. See that these aren't respected

Screenshots

URL from "source"
image

URL after opening in a new tab
image

Error Logs

No response

Desktop

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Browser Version [e.g. 22]

Additional context

No response

@hugovalente-pm hugovalente-pm added bug Something isn't working needs triage labels Apr 2, 2024
@netdata-community-bot
Copy link

This issue has been mentioned on the Netdata Community Forums. There might be relevant details there:

https://community.netdata.cloud/t/before-after-timestamp-doesnt-work-in-url-anymore/5291/2

@BenasPaulikas
Copy link

This must be quite a recent change.
I've used before/after params as timestamp(in ms) for years now.
And only recently it broke.

@novykh
Copy link
Contributor

novykh commented Apr 2, 2024

Fixed and deployed.

@novykh novykh closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants